summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaxim Cournoyer <maxim.cournoyer@gmail.com>2024-12-19 10:46:18 +0900
committerEfraim Flashner <efraim@flashner.co.il>2025-01-06 12:15:09 +0200
commit1997c01437659a01bf6188d5bb203b5507f4144c (patch)
tree0acffec30c552da0edb7e8468ed698fca38d56ce
parent979839cf777b42675db22d4df2cb38a4b5835256 (diff)
build/cargo.scm: Remove '--release' from default cargo-test-flags.
The default behavior for 'cargo test' is to build in debug mode, and many test suites expect support for things provided in this mode such as debug assertions (see for example: <https://github.com/google/zerocopy/issues/2143>). * guix/build-system/cargo.scm (cargo-build): Remove '--release' from #:cargo-test-flags. * guix/build/cargo-build-system.scm (check): Likewise. Change-Id: I8a659c25bd33bc1bdfd88e440bd00bad09a5fc01 Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
-rw-r--r--guix/build-system/cargo.scm4
-rw-r--r--guix/build/cargo-build-system.scm2
2 files changed, 3 insertions, 3 deletions
diff --git a/guix/build-system/cargo.scm b/guix/build-system/cargo.scm
index 9850969156..452f7f78d0 100644
--- a/guix/build-system/cargo.scm
+++ b/guix/build-system/cargo.scm
@@ -93,7 +93,7 @@ to NAME and VERSION."
(test-target #f)
(vendor-dir "guix-vendor")
(cargo-build-flags ''("--release"))
- (cargo-test-flags ''("--release"))
+ (cargo-test-flags ''())
(cargo-package-flags ''("--no-metadata" "--no-verify"))
(features ''())
(skip-build? #f)
@@ -153,7 +153,7 @@ to NAME and VERSION."
(test-target #f)
(vendor-dir "guix-vendor")
(cargo-build-flags ''("--release"))
- (cargo-test-flags ''("--release"))
+ (cargo-test-flags ''())
(cargo-package-flags ''("--no-metadata" "--no-verify"))
(cargo-target (cargo-triplet (or target system)))
(features ''())
diff --git a/guix/build/cargo-build-system.scm b/guix/build/cargo-build-system.scm
index 453d759470..480134402f 100644
--- a/guix/build/cargo-build-system.scm
+++ b/guix/build/cargo-build-system.scm
@@ -252,7 +252,7 @@ directory = '" vendor-dir "'") port)
parallel-build?
parallel-tests?
tests?
- (cargo-test-flags '("--release"))
+ (cargo-test-flags '())
#:allow-other-keys)
"Run tests for a given Cargo package."
(when tests?